Skip to content

[19.0][MIG] report_positioned_image: Migration to 19.0 - #1193

Merged
OCA-git-bot merged 6 commits into
OCA:19.0from
qrtl:19.0-add-report_positioned_image
Sep 10, 2026
Merged

[19.0][MIG] report_positioned_image: Migration to 19.0#1193
OCA-git-bot merged 6 commits into
OCA:19.0from
qrtl:19.0-add-report_positioned_image

Conversation

@AungKoKoLin1997

@AungKoKoLin1997 AungKoKoLin1997 commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

@qrtl QT7096

@OCA-git-bot OCA-git-bot added series:19.0 mod:report_positioned_image Module report_positioned_image labels Aug 28, 2026

@yostashiro yostashiro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and functional test. LGTM.

@yostashiro

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Sorry @yostashiro you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@yostashiro

Copy link
Copy Markdown
Member

Oops. This was a mistake. Apologies for the noise: #1193 (comment)

yostashiro added a commit to qrtl/ocj-oca that referenced this pull request Aug 28, 2026
…ity (#35)

Vendors two OCA modules from `OCA/reporting-engine`:

| Module | Source | Commit |
|---|---|---|
| `report_positioned_image` | [#1193](OCA/reporting-engine#1193) (open, not yet on `19.0`) | `30d0138` |
| `report_qweb_element_page_visibility` | `19.0` branch | `b730d60` |

The second is a dependency of the first and is not otherwise reachable from this project's addons path, since ocj aggregates no upstream OCA repositories. It is already on the upstream `19.0` branch, so that copy is redundant with upstream and can be retired if `reporting-engine` is ever aggregated directly.

Each module's origin is recorded below as a `Vendored from <repo>@<sha> (<ref>)` line, so a later re-sync can tell which upstream commit the copy is — which matters most for `report_positioned_image`, whose source is a PR head that can move or be closed.

[QT7096](https://www.quartile.co/web#id=7096&cids=3&menu_id=506&action=1457&model=project.task&view_type=form)

Vendored from OCA/reporting-engine@30d0138 (refs/pull/1193/head)
Vendored from OCA/reporting-engine@b730d60 (19.0)

Assisted-by: Claude Opus 5

@smorita7749 smorita7749 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review: LGTM

@HviorForgeFlow

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 19.0-ocabot-merge-pr-1193-by-HviorForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit 076416a into OCA:19.0 Sep 10, 2026
5 of 7 checks passed
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at a1ecb5d. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants