[19.0][MIG] report_positioned_image: Migration to 19.0 - #1193
Conversation
Currently translated at 100.0% (30 of 30 strings) Translation: reporting-engine-18.0/reporting-engine-18.0-report_positioned_image Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-18-0/reporting-engine-18-0-report_positioned_image/it/
yostashiro
left a comment
There was a problem hiding this comment.
Code review and functional test. LGTM.
|
/ocabot merge nobump |
|
Sorry @yostashiro you are not allowed to merge. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
|
Oops. This was a mistake. Apologies for the noise: #1193 (comment) |
…ity (#35) Vendors two OCA modules from `OCA/reporting-engine`: | Module | Source | Commit | |---|---|---| | `report_positioned_image` | [#1193](OCA/reporting-engine#1193) (open, not yet on `19.0`) | `30d0138` | | `report_qweb_element_page_visibility` | `19.0` branch | `b730d60` | The second is a dependency of the first and is not otherwise reachable from this project's addons path, since ocj aggregates no upstream OCA repositories. It is already on the upstream `19.0` branch, so that copy is redundant with upstream and can be retired if `reporting-engine` is ever aggregated directly. Each module's origin is recorded below as a `Vendored from <repo>@<sha> (<ref>)` line, so a later re-sync can tell which upstream commit the copy is — which matters most for `report_positioned_image`, whose source is a PR head that can move or be closed. [QT7096](https://www.quartile.co/web#id=7096&cids=3&menu_id=506&action=1457&model=project.task&view_type=form) Vendored from OCA/reporting-engine@30d0138 (refs/pull/1193/head) Vendored from OCA/reporting-engine@b730d60 (19.0) Assisted-by: Claude Opus 5
smorita7749
left a comment
There was a problem hiding this comment.
Code and functional review: LGTM
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at a1ecb5d. Thanks a lot for contributing to OCA. ❤️ |
@qrtl QT7096